Skip to content

feat(locale): add sl_SI locale, location module#3652

Merged
ST-DDT merged 34 commits into
faker-js:nextfrom
ZigaVukcevicDev:feat/locale-sl-SI-location
Apr 6, 2026
Merged

feat(locale): add sl_SI locale, location module#3652
ST-DDT merged 34 commits into
faker-js:nextfrom
ZigaVukcevicDev:feat/locale-sl-SI-location

Conversation

@ZigaVukcevicDev
Copy link
Copy Markdown
Contributor

No description provided.

@ZigaVukcevicDev ZigaVukcevicDev requested a review from a team as a code owner November 6, 2025 15:33
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 6, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3b63b8
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69d3695099e2d00008bc36b3
😎 Deploy Preview https://deploy-preview-3652.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (753bec6) to head (b3b63b8).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3652   +/-   ##
=======================================
  Coverage   98.88%   98.89%           
=======================================
  Files         886      887    +1     
  Lines        3063     3064    +1     
  Branches      556      556           
=======================================
+ Hits         3029     3030    +1     
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/locales/sl_SI/index.ts 100.00% <ø> (ø)
src/locales/sl_SI/location/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matthewmayer
matthewmayer previously approved these changes Nov 13, 2025
@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature c: locale Permutes locale definitions m: location Something is referring to the location module labels Dec 14, 2025
@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Dec 14, 2025
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review.

I don't speak Slovenian, so my suggestions are just what I found during the review.
Could you please check whether your version/the suggestion is correct?

Comment thread src/locales/sl_SI/location/city_name.ts Outdated
Comment thread src/locales/sl_SI/location/country.ts Outdated
Comment thread src/locales/sl_SI/location/country.ts
Comment thread src/locales/sl_SI/location/secondary_address.ts Outdated
Comment thread src/locales/sl_SI/location/state_abbr.ts Outdated
Comment thread src/locales/sl_SI/location/state.ts
Comment thread src/locales/sl_SI/location/state.ts
Comment thread src/locales/sl_SI/location/street_name.ts
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Mar 31, 2026

@ZigaVukcevicDev Can you please check my comments?

@ZigaVukcevicDev
Copy link
Copy Markdown
Contributor Author

@ST-DDT I will check it in couple of days. Thank you.

@ZigaVukcevicDev
Copy link
Copy Markdown
Contributor Author

@ST-DDT comments resolved.

@ST-DDT ST-DDT enabled auto-merge April 6, 2026 08:06
@ST-DDT ST-DDT added this pull request to the merge queue Apr 6, 2026
Merged via the queue into faker-js:next with commit 28d4f7c Apr 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: location Something is referring to the location module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants